Open
Conversation
jdhudson3
reviewed
Oct 15, 2024
jdhudson3
reviewed
Oct 16, 2024
jdhudson3
reviewed
Oct 17, 2024
jdhudson3
previously approved these changes
Oct 17, 2024
…etrics-agent into azure-blob-upload-support
jdhudson3
reviewed
Dec 31, 2024
jdhudson3
previously approved these changes
Jan 7, 2025
daniel-spray
reviewed
Jan 7, 2025
jdhudson3
previously approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for uploading to a custom Azure blob storage. Also adds support for azure managed identity blob storage uploads.
Where should the reviewer start?
How should this be manually tested?
Created an image based on this build and applied the image to a metrics-agent yaml.
Set all custom azure env vars with the correct values.
Deployed that metrics-agent to a test cluster.
Confirm uploads to the Azure blob container name provided.
Tested the default upload with this new image to ensure backwards compatibility.
Any background context you want to provide?
What picture best describes this PR (optional but encouraged)?
What are the relevant Github Issues?
Developer Done List
For the Reviewer:
By approving this PR, the reviewer acknowledges that they have checked all items in this done list.
Reviewer/Approval Done List